New tagging vsphere feature #54058
Merged
New tagging vsphere feature #54058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
removed their request for review
waynew
reviewed
Jul 29, 2019
waynew
approved these changes
Jul 29, 2019
waynew
suggested changes
Jul 29, 2019
twangboy
approved these changes
Jul 29, 2019
s0undt3ch
reviewed
Jul 30, 2019
requirements/tests.txt
Outdated
| @@ -20,6 +20,7 @@ supervisor; python_version < '3' | |||
| kubernetes<4.0 | |||
| psutil | |||
| pyvmomi | |||
| vSphere-Automation-SDK | |||
There was a problem hiding this comment.
This should instead be added to requirements/static/*.in as we talked about, likely where pyvmomi is also present, and then the requirements need to be recompiled, pre-commit run -av
There was a problem hiding this comment.
Yep, I'll get that going...
cro
approved these changes
Jul 30, 2019
|
Changes are waiting on a response from this thread: vmware/vsphere-automation-sdk-python#38 |
…ion to util, added docstrings
and add required module to use new methods.
…ion to util, added docstrings
and add required module to use new methods.
… into new_tagging_vsphere_feature
Codecov Report
@@ Coverage Diff @@
## master #54058 +/- ##
=========================================
Coverage ? 24.89%
=========================================
Files ? 286
Lines ? 65762
Branches ? 14817
=========================================
Hits ? 16365
Misses ? 47366
Partials ? 2031
|
|
Windows tests are passing but the builds failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds tagging ability to vcenter proxy through new functions.
.
.
What issues does this PR fix or reference?
#52764
Tests written?
Yes
Commits signed with GPG?
Yes