rest_tornado set session_id cookie #54103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
sbrennan4
force-pushed
the
rest-tornado-set-cookie
branch
from
b727e9c
to
963d69a
Compare
sbrennan4
force-pushed
the
rest-tornado-set-cookie
branch
from
fa874e2
to
42cdb80
Compare
|
Hey @sbrennan4 thanks for the PR! Would you be able to rebase this against |
|
I'll go ahead and close this PR, as I went ahead and did the rebase here: #54103 Of course if you'd rather handle the changes yourself, I'll be happy to re-open this and close mine 👍 |
|
@sbrennan4 FYI, this has been merged to master in #55743 🚀 - thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets the
session_idcookie when a user is authenticated against the rest_tornado backend. This allows clients such asrequeststo work with cookies as expected.What issues does this PR fix or reference?
This is to bring rest_tornado up to parity with rest_cherrypy with respect to cookies.
Previous Behavior
No cookies set.
New Behavior
session_idcookie is set.Tests written?
Yes
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.