-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage wusa 3010 return code #54411
Merged
Merged
Manage wusa 3010 return code #54411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from garethgreenaway
September 5, 2019 10:43
waynew
suggested changes
Sep 6, 2019
Hi, Is it possible to move forward on this ? |
twangboy
approved these changes
Oct 4, 2019
@tlemarchand Could you rebase this against master. And please add some tests. |
…ase of return code different from 0.
@twangboy , I rebased against master, fixed existing tests and added a new test for the 3010 return code. |
dwoz
approved these changes
Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and add additional comment in state in case of return code different from 0.
What does this PR do?
This PR fixes a bug.
If a .msu file installation requires reboot, currently wusa state will fail with an un-catched CommandExecutionError, even if installation is done and requires only a reboot.
Also, this PR adds an additional comment in case of CommandExecutionError, so that we can easily know that a reboot is needed, or in case of failure what is the problem.
What issues does this PR fix or reference?
Previous Behavior
New Behavior
Tests written?
No
Commits signed with GPG?
No