Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Porting #53080 to master #54566

Merged
merged 4 commits into from
Dec 17, 2019
Merged

[master] Porting #53080 to master #54566

merged 4 commits into from
Dec 17, 2019

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 18, 2019 •
edited
Loading

Porting #53080 to master

@garethgreenaway garethgreenaway requested a review from a team September 18, 2019 23:55
@ghost ghost requested review from Ch3LL and removed request for a team September 18, 2019 23:56
@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #53080 to 2019.2.1 [master] Porting #53080 to master Sep 24, 2019
@garethgreenaway garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 22:55
@cmcmarrow cmcmarrow self-assigned this Oct 18, 2019
cmcmarrow
cmcmarrow suggested changes Oct 18, 2019
View reviewed changes
salt/modules/win_pkg.py Outdated Show resolved Hide resolved
@dafyddj
Copy link
Contributor

dafyddj commented Dec 6, 2019

I hope this can make it into the next release, as it is an annoying bug.

@cmcmarrow cmcmarrow requested a review from a team as a code owner December 10, 2019 22:00
@cmcmarrow cmcmarrow self-requested a review December 10, 2019 22:00
@dwoz dwoz merged commit 6d83704 into saltstack:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew left review comments

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@twangboy twangboy twangboy approved these changes

@cmcmarrow cmcmarrow cmcmarrow approved these changes

@Ch3LL Ch3LL Awaiting requested review from Ch3LL

Assignees

@cmcmarrow cmcmarrow

Labels
master-port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@garethgreenaway @dafyddj @waynew @s0undt3ch @twangboy @cmcmarrow @dwoz