Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Backport 50452, 54022) Add new module freezer #54960

Merged
merged 5 commits into from
Dec 24, 2019

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Oct 11, 2019

What does this PR do?

Sometimes we need to have a static picture of the repositories
and packages installed in a system, so we can install new transient
packages (and the dependencies) and be able to go back to a previous
state where those packages are not there anymore.

This module allows the user to take this picture, and revert all
the changes done after this picture. We can remove package,
reinstall packages that are missing, and do the same for repositories.

Tests written?

Yes

(backport #50452, already merged in develop)
(backport #54022, under review)

@aplanas aplanas changed the title (Backport 50452) Add new module freezer (Backport 50452, 54022) Add new module freezer Oct 14, 2019
@waynew waynew self-assigned this Nov 5, 2019
@waynew
Copy link
Contributor

waynew commented Nov 6, 2019

Hey @aplanas thanks for the PR and backport - checking this one out now 😃

salt/modules/freezer.py Outdated Show resolved Hide resolved
salt/modules/freezer.py Outdated Show resolved Hide resolved
salt/modules/freezer.py Outdated Show resolved Hide resolved
salt/modules/freezer.py Outdated Show resolved Hide resolved
doc/topics/releases/neon.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, I think this looks great. There are a couple of comments that I don't think are blockers, but I think they could be improved.

salt/modules/freezer.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the Copyright removal, I'm cool with this PR.

aplanas and others added 5 commits December 3, 2019 11:25
Sometimes we need to have a static picture of the repositories
and packages installed in a system, so we can install new transient
packages (and the dependencies) and be able to go back to a previous
state where those packages are not there anymore.

This module allows the user to take this picture, and revert all
the changes done after this picture. We can remove package,
reinstall packages that are missing, and do the same for repositories.

(cherry picked from commit efcce01)
@aplanas
Copy link
Contributor Author

aplanas commented Dec 5, 2019

If I split it in two, will help the reviews?

@dwoz dwoz merged commit 9dc8ce7 into saltstack:master Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants