-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Backport 50452, 54022) Add new module freezer #54960
Conversation
cba3c9f
to
a2992d4
Compare
Hey @aplanas thanks for the PR and backport - checking this one out now 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, I think this looks great. There are a couple of comments that I don't think are blockers, but I think they could be improved.
a2992d4
to
b26866d
Compare
b26866d
to
7095ce0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the Copyright removal, I'm cool with this PR.
7095ce0
to
1cb9ee7
Compare
Sometimes we need to have a static picture of the repositories and packages installed in a system, so we can install new transient packages (and the dependencies) and be able to go back to a previous state where those packages are not there anymore. This module allows the user to take this picture, and revert all the changes done after this picture. We can remove package, reinstall packages that are missing, and do the same for repositories. (cherry picked from commit efcce01)
1cb9ee7
to
4e1501a
Compare
If I split it in two, will help the reviews? |
What does this PR do?
Sometimes we need to have a static picture of the repositories
and packages installed in a system, so we can install new transient
packages (and the dependencies) and be able to go back to a previous
state where those packages are not there anymore.
This module allows the user to take this picture, and revert all
the changes done after this picture. We can remove package,
reinstall packages that are missing, and do the same for repositories.
Tests written?
Yes
(backport #50452, already merged in develop)
(backport #54022, under review)