-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
master-port 49822 and 52217 #54977
master-port 49822 and 52217 #54977
Conversation
initial xml module/state
include xml state/module in docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Code looks great - a couple of questions about the comments, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think code-wise, this looks good now. Just a couple of tweaks and it looks ready for merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final change(?)
test failures appear to be unrelated to this PR |
What does this PR do?
Ports #49822 and #52217 to master branch
Tests written?
Yes - as originally included
Note: this includes the release notes from Neon as of when this was committed. Might be a conflict'y item in this process.