Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Backport 52182) mdadm_raid: convert metadata to text #55002

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Oct 14, 2019

What does this PR do?

Convert the metadata parameter to text, as can be represented as a float in the pillar (0.9, 1.0, 1.2, etc)

Tests written?

Yes

(backport #52182, already merged in develop)

Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aplanas Looks like the test failures are related

@aplanas
Copy link
Contributor Author

aplanas commented Dec 4, 2019

Ouch. Fixed the test.

@aplanas aplanas requested a review from dwoz December 4, 2019 09:50
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(cherry picked from commit 1e7c682)
@dwoz dwoz merged commit b47787b into saltstack:master Dec 20, 2019
@aplanas aplanas deleted the backport_52182 branch April 7, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants