Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Backport 52304) utils/path.py: fix a DeprecationWarning #55003

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Oct 14, 2019

What does this PR do?

Fix DeprecationWarning about using or importing ABCs from collections,
instead of from 'collections.abc'

Tests written?

No, as this is a deprecation warning emitted by the interpreter. No behavior change.

(backport #52304, already merged in develop)

@dwoz dwoz requested a review from a team as a code owner November 20, 2019 08:00
@ghost ghost requested a review from DmitryKuzmenko November 20, 2019 08:00
Fix DeprecationWarning about using or importing ABCs from collections,
instead of from 'collections.abc'

(cherry picked from commit b19ccb7)
@dhiltonp
Copy link
Contributor

dhiltonp commented Dec 4, 2019

More importantly, collections is removed in 3.9.

We have another ~60 raw imports of collections that need similar treatment.

@dwoz dwoz merged commit aa9e347 into saltstack:master Dec 20, 2019
@aplanas aplanas deleted the backport_52304 branch April 7, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants