-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix novaclient api #55050
Merged
Merged
Fix novaclient api #55050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Akm0d The linter is still failing here. |
Akm0d
force-pushed
the
fix_novaclient_api
branch
from
December 11, 2019 23:51
2cea546
to
c046bd1
Compare
re-run full all |
re-run full windows2016 |
re-run full windows2019 |
re-run full opensuse15 |
s0undt3ch
approved these changes
Dec 12, 2019
Akm0d
added
Needs-Testcase
PR needs test cases written, or the issue is about a bug/feature that needs test cases
and removed
Needs-Testcase
PR needs test cases written, or the issue is about a bug/feature that needs test cases
labels
Dec 12, 2019
dwoz
reviewed
Dec 12, 2019
dwoz
requested changes
Dec 12, 2019
dwoz
reviewed
Dec 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #55050 +/- ##
==========================================
+ Coverage 18.81% 38.3% +19.5%
==========================================
Files 817 1464 +647
Lines 178439 260114 +81675
Branches 38571 54963 +16392
==========================================
+ Hits 33560 99618 +66058
- Misses 142142 149195 +7053
- Partials 2737 11301 +8564
|
2019 windows tests are passing:
merging pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Port #49977 to master