Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Status Code Lists for HTTP Query State #55132

Closed
wants to merge 1 commit into from
Closed

Added Status Code Lists for HTTP Query State #55132

wants to merge 1 commit into from

Conversation

Ajnbro
Copy link
Contributor

@Ajnbro Ajnbro commented Oct 26, 2019

What does this PR do?

This PR allows for individuals to pass a list of strings representing multiple different status codes to the HTTP Query State in order to check if any of the provided status codes are returned by the query. It also creates two additional tests for the HTTP Query State, one for testing this new functionality and one for testing prior functionality.

What issues does this PR fix or reference?

N/A

Previous Behavior

HTTP Query only allowed individuals to specify the status parameter as a string representing a status code or as a regex used to search for specific status codes.

New Behavior

HTTP Query allows individuals to specify the status parameter as a string representing a status code, a list of strings representing multiple status codes, or as a regex used to search for specific status codes.

Tests written?

Yes

Commits signed with GPG?

Yes

@Ajnbro Ajnbro requested a review from a team as a code owner October 26, 2019 00:40
@ghost ghost requested a review from cmcmarrow October 26, 2019 00:40
@bryceml
Copy link
Contributor

bryceml commented Oct 26, 2019

please re-open this pr against the master branch, no further development will happen on the develop branch.

@Ajnbro Ajnbro closed this Oct 28, 2019
@Ajnbro Ajnbro deleted the http_query_update branch October 28, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants