Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #54448 #55374

Merged
merged 1 commit into from
Jan 2, 2020
Merged

fix #54448 #55374

merged 1 commit into from
Jan 2, 2020

Conversation

silenius
Copy link
Contributor

What does this PR do?

Fix a small issue with Python 3

What issues does this PR fix or reference?

#54448

Tests written?

No

@silenius silenius requested a review from a team as a code owner November 20, 2019 12:11
@ghost ghost requested a review from cmcmarrow November 20, 2019 12:11
@dwoz
Copy link
Contributor

dwoz commented Dec 23, 2019

@silenius This needs to be re-based against master since we are no longer accepting merges to 2019.2

@dwoz dwoz changed the base branch from 2019.2 to master January 1, 2020 22:36
@dwoz
Copy link
Contributor

dwoz commented Jan 1, 2020

@silenius I've rebased this and pointed the PR to the master branch.

@silenius
Copy link
Contributor Author

silenius commented Jan 2, 2020

@silenius I've rebased this and pointed the PR to the master branch.

thanks! (.. and sorry for late reply I just returned from holidays)

@dwoz dwoz merged commit 7ac44f0 into saltstack:master Jan 2, 2020
@silenius silenius deleted the issue_54448 branch January 3, 2020 09:31
@L4rS6 L4rS6 mentioned this pull request Feb 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwoz dwoz dwoz approved these changes

@cmcmarrow cmcmarrow Awaiting requested review from cmcmarrow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silenius @dwoz