Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding DNS exec and state modules to master #55424

Merged
merged 5 commits into from
Dec 9, 2019

Conversation

nicholasmhughes
Copy link
Collaborator

@nicholasmhughes nicholasmhughes commented Nov 25, 2019

What does this PR do?

Add Azure DNS modules for crud operations on DNS zones and record sets.

What issues does this PR fix or reference?

N/A

Tests written?

Yes

Commits signed with GPG?

Yes

PORTING TO MASTER FROM #47945

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner November 25, 2019 01:54
@ghost ghost requested a review from xeacott November 25, 2019 01:54
@nicholasmhughes
Copy link
Collaborator Author

@Akm0d , I entered this PR into your tracking spreadsheet

@Akm0d Akm0d added this to the Approved milestone Nov 26, 2019
@Akm0d Akm0d self-assigned this Nov 26, 2019
@dwoz dwoz requested a review from Akm0d December 3, 2019 09:26
@dwoz dwoz added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Dec 3, 2019
@nicholasmhughes
Copy link
Collaborator Author

@Akm0d I added some tests. Let me know what you think.

@dwoz dwoz merged commit fee49b9 into saltstack:master Dec 9, 2019
@nicholasmhughes nicholasmhughes deleted the add-azurearm-dns-modules branch December 9, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master-port Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants