Deprecate hgfs/svnfs_env_whitelist/blacklist #55552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
hgfs_env_whitelistandhgfs_env_blacklistin favor ofhgfs_saltenv_whitelistandhgfs_saltenv_blacklistsvnfs_env_whitelistandsvnfs_env_blacklistin favor ofsvnfs_saltenv_whitelistandsvnfs_saltenv_blacklist.What issues does this PR fix or reference?
#49426
Previous Behavior
Both the
envandsaltenvwhitelist/blacklist options would work in both the hgfs and svnfs fileserver.New Behavior
Only the
saltenvwhitelist/blacklist options will work in the hgfs/svnfs fileserver. The{fileserver}_env_{blacklist|whitelist}option will no longer work.Tests written?
No - Deprecating Code
Commits signed with GPG?
Yes