Add deprecation warning path for glance state and execution module #55592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Ch3LL
changed the title
s0undt3ch
approved these changes
Dec 12, 2019
| @@ -104,7 +104,7 @@ def _auth(profile=None, api_version=2, **connection_args): | |||
| Only intended to be used within glance-enabled modules | |||
| ''' | |||
| __utils__['versions.warn_until']( | |||
There was a problem hiding this comment.
I know this is not your change but why are we preferring __utils__ instead of the direct function call?
You know the reason behind that?
There was a problem hiding this comment.
Personally I thought we always preferred __utils__ where possible since its packed in via the loader instead of importing directly. Is there a reason not to?
There was a problem hiding this comment.
Guess there really isn't a reason, I apparently just dislike it's usage, seems like mixing loader stuff with regular utils modules, but it's just my personal preference.
Codecov Report
@@ Coverage Diff @@
## master #55592 +/- ##
==========================================
- Coverage 39.58% 38.17% -1.41%
==========================================
Files 1484 1463 -21
Lines 265124 259754 -5370
Branches 57299 54886 -2413
==========================================
- Hits 104924 99134 -5790
- Misses 148015 149368 +1353
+ Partials 12185 11252 -933
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add deprecation warning path for glance state and execution module
What issues does this PR fix or reference?
#49414
Previous Behavior
glance module was set to be deprecated in the neon release
New Behavior
glance module will not be deprecated till the Aluminium release. This is because the glance state module which uses the glance module was never set on a deprecation path. So both the glance execution and state modules are set for deprecation in Aluminium.
Tests written?
No - adding deprecation warning
Commits signed with GPG?
Yes