Deprecate jinja filters for neon #55614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
in this pr Backport tojson filter from #48309 to 2018.3 #48339 a note was added in the jinja docs that the
tojsonjinja filter would replacejson_encode_dictandjson_encode_list, but it was never added to the release notes for a release to properly deprecate it. This PR will add this notification in the neon release notes forjson_decode_*as this was improperly named. we will keepjson_encode_*as it still makes sense and we want to decrease users having to update their states.we want to keep
str_to_numandrand_strto ensure users do not have to update their states, but its already documented they these are no the preferred method.Fixes issue #49428