-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly resolve the policy name #56272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwoz
approved these changes
Mar 11, 2020
Ch3LL
reviewed
Mar 11, 2020
twangboy
force-pushed
the
fix_lgpo_names
branch
from
March 11, 2020 16:08
9fbfff2
to
d6e2575
Compare
waynew
suggested changes
Mar 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you missed one of the instances @Ch3LL was referring to 😝
Some states were not resolving the policy name from the refId. Additionally, there was an issue where the element value wasn't being encoded properly
twangboy
force-pushed
the
fix_lgpo_names
branch
from
March 11, 2020 19:18
94433bc
to
a7369e4
Compare
waynew
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some states were not resolving the policy name from the refId.
Additionally, there was an issue where the element value wasn't being encoded properly
What issues does this PR fix or reference?
#44618
Previous Behavior
Policy name could only be set using refId and not the policy name.
lgpo.get_policy_info
would return only the refId's and not the policy name.New Behavior
Policy names are now properly resolved.
lgpo.get_policy_info
now returns policy names:Tests written?
They're coming
Commits signed with GPG?
Yes