-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set state_output_profile as option and update docs #59165
Set state_output_profile as option and update docs #59165
Conversation
Of note: I also opened #59166 after noticing that we may need to extend the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like in JsonNestedTestCase in the setup_loader_modules
function you'll need to add "state_output_profile": True,
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What does this PR do?
state_output_profile
as an option inmaster
andminion
configsstate_output_profile
as an option tosalt/config/__init__.py
, validating as abool
state_output_profile
as having default value ofTrue
inminion
andmaster
configssalt/output/highstate.py
to no longer hard-code default value forstate_output_profile
What issues does this PR fix or reference?
Ongoing work related to: #58112
It looks like
state_output_profile
was meant to be an option, but was instead hard-coded intosalt/output/highstate.py
when the value and option should have been documented for minion/master configurations.Previous Behavior
Undocumented option.
New Behavior
Documented option.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes