Migrate integration.states.test_file to functional tests
#60279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
force-pushed
the
hotfix/migrate-to-functional-4
branch
7 times, most recently
from
9135a3c
to
acb3c76
Compare
s0undt3ch
force-pushed
the
hotfix/migrate-to-functional-4
branch
from
acb3c76
to
5e3436a
Compare
s0undt3ch
force-pushed
the
hotfix/migrate-to-functional-4
branch
2 times, most recently
from
264785e
to
59138c9
Compare
s0undt3ch
force-pushed
the
hotfix/migrate-to-functional-4
branch
from
59138c9
to
f7d548c
Compare
|
Converting to draft again since it needs #63012 and a pytest-salt-factories release. |
s0undt3ch
force-pushed
the
hotfix/migrate-to-functional-4
branch
2 times, most recently
from
1708ba6
to
527d6d6
Compare
|
That PR has been merged... |
s0undt3ch
force-pushed
the
hotfix/migrate-to-functional-4
branch
9 times, most recently
from
2cfa52e
to
fd0d2dc
Compare
s0undt3ch
force-pushed
the
hotfix/migrate-to-functional-4
branch
from
95282f9
to
b55e841
Compare
s0undt3ch
force-pushed
the
hotfix/migrate-to-functional-4
branch
3 times, most recently
from
5c86766
to
1cc2b1b
Compare
twangboy
previously approved these changes
Nov 30, 2022
Ch3LL
previously approved these changes
Nov 30, 2022
In the process, split the tests into sub-modules which target each function tested from the ``file`` state modules. A lot of text files used during testing, which can be created at runtime were also deleted.
This is because the windows function to check the directory only checks ownership and permissions. Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch
force-pushed
the
hotfix/migrate-to-functional-4
branch
from
1cc2b1b
to
41e5ad0
Compare
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch
force-pushed
the
hotfix/migrate-to-functional-4
branch
from
41e5ad0
to
2f9debe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate
integration.states.test_fileto functional testsIn the process, split the tests into sub-modules which target each function tested from the
filestate modules.A lot of text files used during testing, which can be created at runtime were also deleted.