Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for gpgautoimport to refresh_db in the zypperpkg module #62209

Merged
merged 10 commits into from
Dec 16, 2023

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Jun 23, 2022

What does this PR do?

Fixes #42039

Previous Behavior

When using the zypper pkg module a refresh could never import GPG keys.

New Behavior

Now an option is available to enable autoimport of GPG keys. The default is still off

Merge requirements satisfied?

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@mcalmer mcalmer requested a review from a team as a code owner June 23, 2022 08:47
@mcalmer mcalmer requested review from waynew and removed request for a team June 23, 2022 08:47
@mcalmer mcalmer force-pushed the options-for-zypper-refresh branch from 89f4c5c to 3eb2e76 Compare June 23, 2022 08:51
Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put some comments in the code

salt/modules/zypperpkg.py Outdated Show resolved Hide resolved
salt/modules/zypperpkg.py Outdated Show resolved Hide resolved
@mcalmer mcalmer force-pushed the options-for-zypper-refresh branch 2 times, most recently from 77cb658 to 53aed44 Compare June 24, 2022 08:11
vzhestkov
vzhestkov previously approved these changes Jun 24, 2022
Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 thanks for addressing the suggestions

@vzhestkov
Copy link
Contributor

@mcalmer there is a test failing tests.unit.modules.test_zypperpkg.ZypperTestCase.test_refresh_db, could you please fix it?

@mcalmer
Copy link
Contributor Author

mcalmer commented Jun 24, 2022

@vzhestkov should be fixed now

meaksh
meaksh previously approved these changes Jul 6, 2022
@mcalmer mcalmer force-pushed the options-for-zypper-refresh branch from 8b7f7d3 to 3ff93f3 Compare July 11, 2022 09:03
meaksh
meaksh previously approved these changes Jul 11, 2022
meaksh
meaksh previously approved these changes Jan 11, 2023
Copy link
Contributor

@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added some small comment about the "versionadded", other than that LGTM.

salt/modules/zypperpkg.py Outdated Show resolved Hide resolved
salt/modules/zypperpkg.py Outdated Show resolved Hide resolved
@mcalmer mcalmer requested review from agraul and meaksh and removed request for waynew and agraul January 11, 2023 12:55
@mcalmer
Copy link
Contributor Author

mcalmer commented Jan 11, 2023

@waynew I clicked somehow at the wrong place and removed you from reviewers list. This is now a long time open and I think it should be merged now. Please have a look again. Thanks

@mcalmer mcalmer temporarily deployed to ci September 23, 2023 09:39 — with GitHub Actions Inactive
@mcalmer mcalmer temporarily deployed to ci September 23, 2023 09:39 — with GitHub Actions Inactive
@mcalmer mcalmer temporarily deployed to ci September 23, 2023 09:53 — with GitHub Actions Inactive
@mcalmer mcalmer temporarily deployed to ci September 23, 2023 09:59 — with GitHub Actions Inactive
@dwoz dwoz merged commit 19a1edc into saltstack:master Dec 16, 2023
529 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't auto-accept newly added repo's package signing key in SUSE.
6 participants