-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for gpgautoimport to refresh_db in the zypperpkg module #62209
Conversation
89f4c5c
to
3eb2e76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put some comments in the code
77cb658
to
53aed44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 thanks for addressing the suggestions
@mcalmer there is a test failing |
485c287
to
5b0aeaf
Compare
@vzhestkov should be fixed now |
042f8bb
to
61e2b59
Compare
8b7f7d3
to
3ff93f3
Compare
560bf91
to
c9a97e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added some small comment about the "versionadded", other than that LGTM.
@waynew I clicked somehow at the wrong place and removed you from reviewers list. This is now a long time open and I think it should be merged now. Please have a look again. Thanks |
Co-authored-by: Pablo Suárez Hernández <psuarezhernandez@suse.com>
Co-authored-by: Pablo Suárez Hernández <psuarezhernandez@suse.com>
b1cf5c0
to
b793657
Compare
What does this PR do?
Fixes #42039
Previous Behavior
When using the zypper pkg module a refresh could never import GPG keys.
New Behavior
Now an option is available to enable autoimport of GPG keys. The default is still
off
Merge requirements satisfied?
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.