sysctl.persist should check in-memory values event if config is correct #62461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
force-pushed
the
sysctl.persist.2
branch
from
39a203b
to
fc6718a
Compare
On FreeBSD, it ignored the in-memory value if the on-disk value is correct.
asomers
force-pushed
the
sysctl.persist.2
branch
from
fc6718a
to
0d81e14
Compare
Ch3LL
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On FreeBSD, it ignored the in-memory value if the on-disk value is
correct.
What does this PR do?
Fixes the behavior of FreeBSD's sysctl.persist to fix its documentation and match the Linux behavior.
Previous Behavior
If the value was correct in the config file, it would not be updated in memory.
New Behavior
The value will be updated in-memory regardless of whether it is correct in the config file.
Merge requirements satisfied?
Commits signed with GPG?
Yes