Bug 62940 fix cron inconsistency in _write_cron_lines #62941
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
garethgreenaway
added
Needs-Testcase
|
@lufik Thanks for the PR, can you please add a changelog file and some tests. Thanks! |
|
@garethgreenaway I added changelog and I updated the test cases. The failed one is IMHO not related to my change. Docs doesn't need to be changed. |
garethgreenaway
removed
Needs-Testcase
|
@lufik Thanks. I've restated the test that had the failure. |
|
Again the failing test doesn't look connected to the change. |
|
@garethgreenaway is something more needed from me? Or is it now up to you or other salt maintainer? |
|
@lufik We're good to go. Was just waiting for that last test that I restarted to finish and pass. |
|
Congratulations on your first PR being merged! 🎉 |
|
Thanks guys! It was pleasure to cooperate with you. |
What does this PR do?
What issues does this PR fix or reference?
Fixes: Bug #62940
Previous Behavior
See the bug report: #62940
New Behavior
Allow root user to manipulate users crontab via cron.absent.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.