-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import StrictVersion and LooseVersion from setuptools.distutils.verison or setuptools._distutils.version #63352
Conversation
re-run full all |
This PR needs to go through the full test suite. |
@s0undt3ch Actually when I checked late last night it had gone through the full test suite, or whatever test suites we have for PRs with no problem. Which raises the question, why are they failing now ?. Wondering what holes we have in testing to explain the inconsistencies ? |
…on or setuptools._distutils.version, if first not available
re-run full all |
re-run full all |
When this gets merged, can someone update #63257 ? That should get all of the tests passing there 👍 |
I feel like I am 'Waiting for Godot' these two tests, RHEL 7 & 9 are taking forever, over two hours now. |
What does this PR do?
Import StrictVersion and LooseVersion from setuptools.distutils.verison or setuptools._distutils.version if the first attempt to import fails, thus allow for old and newer versions of setuptools.
What issues does this PR fix or reference?
Fixes: #63350
Previous Behavior
Test would fail on Debian 10, due to ImportError, since setuptools._distutils is not available in setuptools v40.8.0 which is current for Debian 10
New Behavior
Works with new and old versions of setuptools, and tests pass.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.