Status.custom eval cleanup and logging betterment. #63880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whytewolf
changed the title
twangboy
previously approved these changes
Mar 14, 2023
MKLeb
previously approved these changes
Mar 15, 2023
Ch3LL
approved these changes
Mar 15, 2023
|
so, this was merged into 3006.x and 3006.x was merged into master making this PR unneeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
removes eval with code useful in testing and reporting proper configurations.
also updates failure condition from stack traces to viable information.
What issues does this PR fix or reference?
Fixes: #63879
Previous Behavior
eval in code that isn't needed.
New Behavior
no eval.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.