Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Fix 64170 #64173

Merged
merged 1 commit into from
Apr 27, 2023
Merged

[3006.x] Fix 64170 #64173

merged 1 commit into from
Apr 27, 2023

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented Apr 26, 2023 •
edited
Loading

What does this PR do?

Fixes issue passing a list of masters to the Windows installer.

What issues does this PR fix or reference?

Fixes: #64170

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@twangboy twangboy requested a review from a team as a code owner April 26, 2023 20:13
@twangboy twangboy requested review from dwoz and removed request for a team April 26, 2023 20:13
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix 64170 [3006.x] Fix 64170 Apr 26, 2023
@twangboy twangboy added this to the Sulfur v3006.1 milestone Apr 26, 2023
cheburakshu
cheburakshu approved these changes Apr 26, 2023
View reviewed changes
Copy link

@cheburakshu cheburakshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@twangboy twangboy temporarily deployed to ci April 26, 2023 22:23 — with GitHub Actions Inactive
@twangboy twangboy temporarily deployed to ci April 26, 2023 22:24 — with GitHub Actions Inactive
@twangboy twangboy temporarily deployed to ci April 26, 2023 22:24 — with GitHub Actions Inactive
@twangboy twangboy temporarily deployed to ci April 27, 2023 01:11 — with GitHub Actions Inactive
@twangboy twangboy temporarily deployed to ci April 27, 2023 01:11 — with GitHub Actions Inactive
@twangboy twangboy temporarily deployed to ci April 27, 2023 01:11 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch merged commit 4d52af1 into saltstack:3006.x Apr 27, 2023
@twangboy twangboy mentioned this pull request Apr 28, 2023
Closed
@twangboy twangboy deleted the fix_64170 branch April 28, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@cheburakshu cheburakshu cheburakshu approved these changes

@dwoz dwoz Awaiting requested review from dwoz dwoz was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
Sulfur v3006.1
Projects
None yet
Milestone
Sulfur v3006.1
Development

Successfully merging this pull request may close these issues.
3 participants
@twangboy @s0undt3ch @cheburakshu