Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Fix various issues with lgpo_reg #64175

Merged
merged 1 commit into from
Apr 27, 2023
Merged

[3006.x] Fix various issues with lgpo_reg #64175

merged 1 commit into from
Apr 27, 2023

Conversation

twangboy
Copy link
Contributor

What does this PR do?

Fixes some issues with the lgpo_reg system:

  • execution module functions return True on success if there is no other output
  • Don't fail when the Registry.pol file is missing
  • Simplify the changes output for states
  • Make the state more idempotent, ie: don't just check that there are changes, make sure the changes are the changes we're expecting

What issues does this PR fix or reference?

Fixes: #64126

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@twangboy twangboy requested a review from a team as a code owner April 27, 2023 00:57
@twangboy twangboy requested review from Ch3LL and removed request for a team April 27, 2023 00:57
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix various issues with lgpo_reg [3006.x] Fix various issues with lgpo_reg Apr 27, 2023
@twangboy twangboy requested a review from MKLeb April 27, 2023 00:57
@twangboy twangboy added this to the Sulfur v3006.1 milestone Apr 27, 2023
@twangboy twangboy temporarily deployed to ci April 27, 2023 01:18 — with GitHub Actions Inactive
@twangboy twangboy temporarily deployed to ci April 27, 2023 01:18 — with GitHub Actions Inactive
@twangboy twangboy temporarily deployed to ci April 27, 2023 01:19 — with GitHub Actions Inactive
@twangboy twangboy temporarily deployed to ci April 27, 2023 02:29 — with GitHub Actions Inactive
@twangboy twangboy temporarily deployed to ci April 27, 2023 02:29 — with GitHub Actions Inactive
@twangboy twangboy temporarily deployed to ci April 27, 2023 02:29 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch merged commit 54be720 into saltstack:3006.x Apr 27, 2023
@twangboy twangboy mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@Ch3LL Ch3LL Awaiting requested review from Ch3LL Ch3LL was automatically assigned from saltstack/team-core

@MKLeb MKLeb Awaiting requested review from MKLeb

Assignees
No one assigned
Labels
Sulfur v3006.1
Projects
None yet
Milestone
Sulfur v3006.1
Development

Successfully merging this pull request may close these issues.
2 participants
@twangboy @s0undt3ch