-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Update 3006 packaging to reduce permissions given to salt user for running salt-master #64194
Merged
garethgreenaway
merged 23 commits into
saltstack:3006.x
from
barneysowood:3006-package-user-changes
Aug 16, 2023
Merged
[3006.x] Update 3006 packaging to reduce permissions given to salt user for running salt-master #64194
garethgreenaway
merged 23 commits into
saltstack:3006.x
from
barneysowood:3006-package-user-changes
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
Update 3006 packaging to reduce permissions given to salt user for running salt-master
[master] Update 3006 packaging to reduce permissions given to salt user for running salt-master
Apr 29, 2023
This is going to be affected by #64174 |
6 tasks
twangboy
previously approved these changes
May 1, 2023
As discussed in #64174, will wait for that to be merged then re-base this and integrate on top of those changes. |
Note that issues in #64219 will affect this. |
Closed
1 task
barneysowood
force-pushed
the
3006-package-user-changes
branch
from
May 12, 2023 13:03
ec17cef
to
7945adc
Compare
salt-project-bot-prod-environment
bot
changed the title
[master] Update 3006 packaging to reduce permissions given to salt user for running salt-master
[3006.x] Update 3006 packaging to reduce permissions given to salt user for running salt-master
May 12, 2023
barneysowood
force-pushed
the
3006-package-user-changes
branch
from
May 12, 2023 14:07
7945adc
to
492759c
Compare
Ch3LL
approved these changes
Aug 16, 2023
MKLeb
approved these changes
Aug 16, 2023
dmurphy18
approved these changes
Aug 16, 2023
dwoz
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates Debian and RPM packages to improve isolation offered by running the
salt-master
processes under thesalt
user.Implementation of running salt-master as a non-root user by default introduced in #64037, gives ownership of shared salt directories to the
salt
user to mitigate a number of issues with running thesalt-master
as a non-root user. This PR aims to reduce the scope of those permission grants to increase isolation of thesalt-master
processes running under thesalt
user - see #64193 for more detail.What issues does this PR fix or reference?
Fixes: #64193
Previous Behavior
The
salt
user that thesalt-master
process runs as was able to:/opt/saltstack/salt
modifying the salt install, including python, shared libs and python modules used by both the salt master and other salt process (egsalt-api
andsalt-minion
) which run as root, compromising the isolation offered by running thesalt-master
as a non-root user./etc/salt
for other salt daemons (that run as root) compromising the isolation offered by running as a non-root user./etc/salt/pki/minion
and/var/cache/salt/minion
again compromising isolation.New Behavior
Debian and RPM packages will now:
/opt/saltstack/salt
hierarchy asroot:root
to prevent modification bysalt-master
process/opt/saltstack/salt/lib/
on install so that performance isn't compromised and the bytecompiled modules are owned by root/opt/saltstack/salt/lib
on uninstallThis should ensure that a compromised
salt-master
process cannot:salt-minion
running on the same hostMerge requirements satisfied?
Commits signed with GPG?
No