[master] Fix 64256: Add flags to create local users and groups #64257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesliverx
force-pushed
the
local-accounts
branch
from
8f9c64d
to
b41c3f5
Compare
|
Apologies, a recent change to pre-commit to make the code compatible with 3.8 and above due to 3.7 becoming end of life soon was recently merged. Do you mind fixing that pre-commit failure? If not I can certainly push up a change. |
bluesliverx
force-pushed
the
local-accounts
branch
from
cab2e21
to
7571bfe
Compare
|
@Ch3LL done! I did it earlier for the latest commit, but now applied it to the original commit as well. |
Ch3LL
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
localflag for user/group creation to force users and groups to be created locally instead of in a remotely managed account management system (e.g. LDAP).What issues does this PR fix or reference?
Fixes: #64256
New Behavior
If the
localflag is specified as truthy, theluseradd,lgroupadd, etc commands will be used instead. If these do not exist on the system, this will fail.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No