-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Ensure runners properly save information to job cache #65023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
[WIP] Ensure runners properly save information to job cache
[3006.x][WIP] Ensure runners properly save information to job cache
Aug 22, 2023
Ch3LL
changed the title
[3006.x][WIP] Ensure runners properly save information to job cache
[3006.x] Ensure runners properly save information to job cache
Aug 22, 2023
s0undt3ch
suggested changes
Aug 23, 2023
s0undt3ch
approved these changes
Aug 23, 2023
9 tasks
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures we properly save the job when we run a job from a runner. This resulted in an error when running
jobs.list_job <jid
for the previously run runner job.What issues does this PR fix or reference?
Fixes: #64570
Previous Behavior
Note the error:
Cannot contact returner or no job with this jid
. This occurs when listing jobs from runner commands.New Behavior