Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Ensure runners properly save information to job cache #65023

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Aug 22, 2023

What does this PR do?

Ensures we properly save the job when we run a job from a runner. This resulted in an error when running jobs.list_job <jid for the previously run runner job.

What issues does this PR fix or reference?

Fixes: #64570

Previous Behavior

(py-3.10)  ch3ll@megan-precision5550  ~/git/salt  ➦ 0b1503cacb <B>  salt-run jobs.list_job 20230822040051543846
Error:
    Cannot contact returner or no job with this jid
Result:
    ----------
    megan-precision5550_master:
        ----------
        return:
            ----------
            _stamp:
                2023-08-22T04:00:51.897435
            fun:
                runner.test.arg
            fun_args:
                - go
                - home
            jid:
                20230822040051543846
            return:
                ----------
                args:
                    - go
                    - home
                kwargs:
                    ----------
            success:
                True
            user:
                sudo_ch3ll
StartTime:
    2023, Aug 22 04:00:51.543846
jid:
    20230822040051543846

Note the error: Cannot contact returner or no job with this jid . This occurs when listing jobs from runner commands.

New Behavior

(py-3.10)  ch3ll@megan-precision5550  ~/git/salt   fix_jobs_list <B>  salt-run jobs.list_job 20230822035942812457
Arguments:
Function:
    runner.test.arg
Result:
    ----------
    megan-precision5550_master:
        ----------
        return:
            ----------
            _stamp:
                2023-08-22T03:59:43.182416
            fun:
                runner.test.arg
            fun_args:
                - go
                - home
            jid:
                20230822035942812457
            return:
                ----------
                args:
                    - go
                    - home
                kwargs:
                    ----------
            success:
                True
            user:
                sudo_ch3ll
StartTime:
    2023, Aug 22 03:59:42.812457
Target:
    megan-precision5550_master
Target-type:
    list
User:
    sudo_ch3ll
jid:
    20230822035942812457

@Ch3LL Ch3LL requested a review from a team as a code owner August 22, 2023 04:03
@Ch3LL Ch3LL requested review from dwoz and removed request for a team August 22, 2023 04:03
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [WIP] Ensure runners properly save information to job cache [3006.x][WIP] Ensure runners properly save information to job cache Aug 22, 2023
@Ch3LL Ch3LL added the test:full Run the full test suite label Aug 22, 2023
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 04:41 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 04:41 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 04:41 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 04:41 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 04:59 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 04:59 — with GitHub Actions Inactive
@Ch3LL Ch3LL changed the title [3006.x][WIP] Ensure runners properly save information to job cache [3006.x] Ensure runners properly save information to job cache Aug 22, 2023
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 16:38 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 16:38 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 16:38 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 16:38 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 16:54 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 16:59 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 19:42 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 19:42 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 19:42 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 19:42 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 19:42 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 22, 2023 19:42 — with GitHub Actions Inactive
tests/pytests/functional/utils/test_job.py Outdated Show resolved Hide resolved
tests/pytests/integration/runners/test_jobs.py Outdated Show resolved Hide resolved
tests/pytests/integration/runners/test_jobs.py Outdated Show resolved Hide resolved
tests/pytests/integration/runners/test_jobs.py Outdated Show resolved Hide resolved
tests/pytests/integration/runners/test_jobs.py Outdated Show resolved Hide resolved
tests/pytests/integration/runners/test_jobs.py Outdated Show resolved Hide resolved
tests/pytests/integration/runners/test_jobs.py Outdated Show resolved Hide resolved
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 17:06 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 17:06 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 17:06 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 17:06 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 17:23 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 17:23 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 20:29 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 20:29 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 20:29 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 20:29 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 20:29 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 23, 2023 20:29 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch merged commit c2a1567 into saltstack:3006.x Aug 24, 2023
321 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:full Run the full test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants