[3006.x] Preserve ownership on log rotation #65290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurphy18
changed the title
dmurphy18
force-pushed
the
fix_65288
branch
from
492dcbb
to
90d7889
Compare
twangboy
approved these changes
Nov 7, 2023
whytewolf
approved these changes
Nov 7, 2023
twangboy
approved these changes
Nov 9, 2023
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Does not force new log files on log rotation to have salt:salt ownership but leave the ownership as to what the salt-master is currently configured, that is, salt-master configuration file user: dog, then dog owns the log files after rotation. Changing the ownership of the key log file, halts the salt-master for example.
What issues does this PR fix or reference?
Fixes:#65288
Previous Behavior
Log files were forced to salt user and group ownership after log rotation
New Behavior
Log files were maintained the user and group ownership after log rotation, as found in the salt-master's configuration file
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.