Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Artifactory module basic auth fix #65642

Merged
merged 4 commits into from
Dec 28, 2023
Merged

[master] Artifactory module basic auth fix #65642

merged 4 commits into from
Dec 28, 2023

Conversation

ubrix
Copy link
Contributor

@ubrix ubrix commented Nov 29, 2023 •
edited
Loading

What does this PR do?

This fixes issue with basic auth causing invalid header error and 401 Bad Request.
Fixed by using HTTPBasicAuthHandler instead of header.

What issues does this PR fix or reference?

Fixes: #58936

Previous Behavior

When setting username and password you received an error.

New Behavior

When setting username and password it works.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@welcome Welcome
Copy link

welcome bot commented Nov 29, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Artifactory module basic auth fix [master] Artifactory module basic auth fix Nov 29, 2023
@ubrix ubrix marked this pull request as ready for review November 29, 2023 09:50
@ubrix ubrix requested a review from a team as a code owner November 29, 2023 09:50
@ubrix ubrix requested review from twangboy and removed request for a team November 29, 2023 09:50
dwoz
dwoz requested changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog

@dwoz dwoz added this to the Argon v3008.0 milestone Dec 18, 2023
@ubrix
Artifactory module basic auth fix
c1a6129 
This fixes issue with basic auth causing 401 Bad Request.
Using HTTPBasicAuthHandler instead of header.
@ubrix
Added changelog
9329942
@ubrix
Copy link
Contributor Author

ubrix commented Dec 18, 2023

Needs changelog

Added changelog

twangboy
twangboy previously approved these changes Dec 18, 2023
View reviewed changes
@twangboy twangboy requested a review from dwoz December 18, 2023 15:39
@dwoz dwoz modified the milestones: Argon v3008.0, Chlorine v3007.0 Dec 28, 2023
@dwoz dwoz merged commit 343b764 into saltstack:master Dec 28, 2023
1061 checks passed
@welcome Welcome
Copy link

welcome bot commented Dec 28, 2023

Congratulations on your first PR being merged! 🎉

@ubrix ubrix deleted the fix_basic_auth_artifactory branch January 3, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy approved these changes

@dwoz dwoz Awaiting requested review from dwoz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Chlorine v3007.0
Development

Successfully merging this pull request may close these issues.

Use API Key in module artifactory download
3 participants
@ubrix @dwoz @twangboy