[3006.x] Don't needlessly refresh fileserver backends during Pillar rendering

[terminalmage]

What does this PR do?

This uses the opts key that masterless runs use to limit fileserver backend refreshes to a single refresh. Adding it to the master opts ensures that FSChan instances created on the master do not trigger fileserver backend refreshes.

What issues does this PR fix or reference?

Fixes #65990

Previous Behavior

Fileserver backends are refreshed when the master instantiates an FSClient instance.

New Behavior

Fileserver backends are no longer refreshed.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[dmurphy18]

The tests case needs to be under tests/pytest and using pytest to test with.
Tests under tests/unit are considered unittest and will eventually be removed.

All tests PR's need tests now written using pytest, are they will be rejected.

[terminalmage]

The tests case needs to be under tests/pytest and using pytest to test with. Tests under tests/unit are considered unittest and will eventually be removed.

All tests PR's need tests now written using pytest, are they will be rejected.

You don't write tests using pytest. You run them using pytest, as I did before submitting this PR.

I brought this up with @dmurphy18 in Slack, but the above is directly contradicted by the following docs pages:

• https://docs.saltproject.io/en/latest/topics/development/contributing.html
• https://docs.saltproject.io/en/latest/topics/tutorials/writing_tests.html

Additionally, the location where tests should be added is not covered by the recent changes to Project Management. Both the above two pages should arguably be linked from this page.

With two distinct sets of tests in the repo, it's a must to get this documentation updated to reflect the current policies of the project. Failure to do so increases the burden placed on the core team, as well as the contributors.

I've moved the tests over. I'm also available to assist in the process of updating the docs so that they more accurately reflect reality, provided I can get better clarity on the changes to these policies.