[3007.x] Fix pillar.ls doesn't accept kwargs #66263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
twangboy
approved these changes
Mar 26, 2024
s0undt3ch
suggested changes
Mar 26, 2024
s0undt3ch
suggested changes
Mar 27, 2024
There was a problem hiding this comment.
Just because something was not done right(at least to today's wanted standards), it does not mean we can't start fixing it early on without tackling the full length of it.
This way you address the problem you wanted to fix, without increasing the future burden of the underlying bigger problem.
s0undt3ch
approved these changes
Mar 28, 2024
twangboy
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See issue for details.
What issues does this PR fix or reference?
Fixes: #66262
Previous Behavior
Error if kwargs are passed.
New Behavior
kwargs are passed to
pillar.itemsMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.