Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Remove perms from linux_acl.list_absent docstring #66892

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

tacerus
Copy link

@tacerus tacerus commented Sep 15, 2024

Not a valid argument for this function, remove misleading documentation reference.

What does this PR do?

What issues does this PR fix or reference?

Fixes #66891.

Previous Behavior

Misleading documentation block.

New Behavior

Less misleading documentation. ;-)

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@tacerus tacerus requested a review from a team as a code owner September 15, 2024 21:55
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Remove perms from linux_acl.list_absent docstring [master] Remove perms from linux_acl.list_absent docstring Sep 15, 2024
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this on 3006.x branch

Not a valid argument for this function, remove misleading documentation
reference.

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
@tacerus
Copy link
Author

tacerus commented Sep 17, 2024

Done, but I can't change the PR target branch.

@twangboy twangboy changed the base branch from master to 3006.x September 18, 2024 17:36
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] Remove perms from linux_acl.list_absent docstring [3006.x] Remove perms from linux_acl.list_absent docstring Sep 18, 2024
@dwoz dwoz merged commit 4e429ef into saltstack:3006.x Oct 17, 2024
181 checks passed
Copy link

welcome bot commented Oct 17, 2024

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] linux_acl.list_absent does not support "perms"
4 participants