-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Remove perms from linux_acl.list_absent docstring #66892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
Remove perms from linux_acl.list_absent docstring
[master] Remove perms from linux_acl.list_absent docstring
Sep 15, 2024
twangboy
approved these changes
Sep 17, 2024
twangboy
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this on 3006.x branch
Not a valid argument for this function, remove misleading documentation reference. Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
Done, but I can't change the PR target branch. |
salt-project-bot-prod-environment
bot
changed the title
[master] Remove perms from linux_acl.list_absent docstring
[3006.x] Remove perms from linux_acl.list_absent docstring
Sep 18, 2024
twangboy
approved these changes
Sep 18, 2024
Akm0d
approved these changes
Sep 23, 2024
Congratulations on your first PR being merged! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a valid argument for this function, remove misleading documentation reference.
What does this PR do?
What issues does this PR fix or reference?
Fixes #66891.
Previous Behavior
Misleading documentation block.
New Behavior
Less misleading documentation. ;-)
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes