Skip to content

Commit

Permalink
doc: modernize child_process example code
Browse files Browse the repository at this point in the history
1. equal => strictEqual.
2. let => const for the variable that is not reassigned.
3. fix spaces.
4. stringify erroneous raw buffer outputs.
5. fix a typo.

PR-URL: nodejs#10102
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
vsemozhetbyt authored and sam-github committed Dec 12, 2016
1 parent 10929f6 commit f418a22
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions doc/api/child_process.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,11 @@ const spawn = require('child_process').spawn;
const bat = spawn('cmd.exe', ['/c', 'my.bat']);

bat.stdout.on('data', (data) => {
console.log(data);
console.log(data.toString());
});

bat.stderr.on('data', (data) => {
console.log(data);
console.log(data.toString());
});

bat.on('exit', (code) => {
Expand All @@ -113,7 +113,7 @@ exec('my.bat', (err, stdout, stderr) => {
});

// Script with spaces in the filename:
const bat = spawn('"my script.cmd"', ['a', 'b'], { shell:true });
const bat = spawn('"my script.cmd"', ['a', 'b'], { shell: true });
// or:
exec('"my script.cmd" a b', (err, stdout, stderr) => {
// ...
Expand Down Expand Up @@ -383,7 +383,7 @@ ps.on('close', (code) => {
});

grep.stdout.on('data', (data) => {
console.log(`${data}`);
console.log(data.toString());
});

grep.stderr.on('data', (data) => {
Expand Down Expand Up @@ -467,8 +467,8 @@ const out = fs.openSync('./out.log', 'a');
const err = fs.openSync('./out.log', 'a');

const child = spawn('prg', [], {
detached: true,
stdio: [ 'ignore', out, err ]
detached: true,
stdio: [ 'ignore', out, err ]
});

child.unref();
Expand Down Expand Up @@ -860,7 +860,7 @@ as in this example:
'use strict';
const spawn = require('child_process').spawn;

let child = spawn('sh', ['-c',
const child = spawn('sh', ['-c',
`node -e "setInterval(() => {
console.log(process.pid, 'is alive')
}, 500);"`
Expand Down Expand Up @@ -1107,21 +1107,21 @@ const fs = require('fs');
const child_process = require('child_process');

const child = child_process.spawn('ls', {
stdio: [
0, // Use parents stdin for child
'pipe', // Pipe child's stdout to parent
fs.openSync('err.out', 'w') // Direct child's stderr to a file
]
stdio: [
0, // Use parent's stdin for child
'pipe', // Pipe child's stdout to parent
fs.openSync('err.out', 'w') // Direct child's stderr to a file
]
});

assert.equal(child.stdio[0], null);
assert.equal(child.stdio[0], child.stdin);
assert.strictEqual(child.stdio[0], null);
assert.strictEqual(child.stdio[0], child.stdin);

assert(child.stdout);
assert.equal(child.stdio[1], child.stdout);
assert.strictEqual(child.stdio[1], child.stdout);

assert.equal(child.stdio[2], null);
assert.equal(child.stdio[2], child.stderr);
assert.strictEqual(child.stdio[2], null);
assert.strictEqual(child.stdio[2], child.stderr);
```

### child.stdout
Expand Down

0 comments on commit f418a22

Please sign in to comment.