Fix convex bouncyness #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PUik to netstandard2.0. Bumped version to 1.5.1.
…ded. Updated XUnit
# Conflicts: # BEPUik/BEPUik.csproj # BEPUphysics.sln # BEPUphysics/BEPUphysics.csproj # BEPUphysicsDemos.sln # BEPUphysicsDemos/Demos/EarthquakeDemo.cs # BEPUutilities/BEPUutilities.csproj # README.md
…x to later multiply by y. Fixed by doing y/x instead
woodywu
pushed a commit
to woodywu/bepuphysics1int
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for this bug explained on the forum: https://forum.bepuentertainment.com/viewtopic.php?f=9&t=2507&start=15#p14064
There are several things here aside from this fix:
The problem lies with the precision lost when doing
1/xand then multiplying it byyinstead of dividing directlyy/x, probably to optimize given that division is slower.