-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: use symbolic name in go-version #314
workflows: use symbolic name in go-version #314
Conversation
🎉 All dependencies have been resolved ! |
This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch. |
@Mergifyio rebase |
❌ Base branch update has failedGit reported the following error:
err-code: 06DC6 |
7c39826
to
d6f7e2f
Compare
🎉 All dependencies have been resolved ! |
The actions/setup-go action has supported symbolic names of `stable` and `oldstable` for a bit. Instead of having to constantly update the workflow every time Go does a new release use the `oldstable` keyword in our workflow so that we're always testing with the older stable release of Go. We choose the older stable version because we do not want to accidentally introduce something new that requires a feature of the newer Go release. Signed-off-by: John Mulligan <jmulligan@redhat.com>
d6f7e2f
to
dc7385f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's cool.
Depends on: #313
Depends on: #288
The workflow files that use Go directly (as opposed to inside a container) use actions/setup-go - this action gained an ability to use "relative versions" of
stable
andoldstable
in the last year or two.Switch our workflow file to use
oldstable
rather than a specific version number in order to keep up with releases from Go upstream. Useoldstable
as to ensure the older but still actively maintained version of Go works.This doesn't handle the container image... that's a WIP project for another PR.