Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nth: addressing #136 - fixing -1 bug on slice of length 1. #137

Merged
merged 1 commit into from
Jul 3, 2022
Merged

Nth: addressing #136 - fixing -1 bug on slice of length 1. #137

merged 1 commit into from
Jul 3, 2022

Conversation

crunk1
Copy link
Contributor

@crunk1 crunk1 commented May 18, 2022

  • Fixed incorrect Nth behavior for -1 index.
  • More performant index checking (haven't tested, but removed Math.Abs call and casting to/from float64)

Used constraints.Integer for 'nth' parameter.
Panic instead of raising error on out of range.

@crunk1
Copy link
Contributor Author

crunk1 commented May 18, 2022

Addressing #136

@dolmen
Copy link
Contributor

dolmen commented Jun 3, 2022

Too many changes which are not related to #136. For example you changed the Nth signature.

Please do separate PRs.

@crunk1
Copy link
Contributor Author

crunk1 commented Jun 3, 2022

@dolmen removed unrelated changes. Other changes are in PR #151

@crunk1 crunk1 changed the title Nth: addressing #136. Nth: addressing #136 - fixing -1 bug on slice of length 1. Jun 6, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@305f565). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #137   +/-   ##
=========================================
  Coverage          ?   89.88%           
=========================================
  Files             ?       12           
  Lines             ?     1325           
  Branches          ?        0           
=========================================
  Hits              ?     1191           
  Misses            ?      132           
  Partials          ?        2           
Flag Coverage Δ
unittests 89.88% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305f565...603bb4f. Read the comment docs.

@samber
Copy link
Owner

samber commented Jul 3, 2022

Oops.

Thanks for the fix.

@samber samber merged commit c77a9c0 into samber:master Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants