-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slice Splice an element or multiple elements at index i. #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks good to me, anything preventing this from being merged? Would like to make use of it
On second glance, something seems off
Running a benchmark of this seems way off from how I would expect an insert to look.
|
fc58c98
to
8809c7b
Compare
Thank you. After testing, it is indeed as you said, and I modified it again, this is my test result goos: darwin BenchmarkInsert-8 100000000 13.07 ns/op |
Wow, the difference between both versions is impressive! Sorry for the delay. I like your helper, but I'm not sure calling it JS, PHP, C++ and Rust named it "splice". |
And I think we should leverage vaargs to write a single helper instead of 2. |
00663d1
to
fec056c
Compare
@samber Thank you for your suggestion. I found that it can be further optimized, and I have already done it. Additionally, the name 'Insert' is borrowed from Ruby's Array#insert, though 'Splice' is also a good name. |
fec056c
to
0066bed
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #371 +/- ##
==========================================
- Coverage 94.30% 94.12% -0.18%
==========================================
Files 17 17
Lines 2633 2640 +7
==========================================
+ Hits 2483 2485 +2
- Misses 148 151 +3
- Partials 2 4 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
slice_test.go
Outdated
@@ -801,3 +801,16 @@ func TestIsSortedByKey(t *testing.T) { | |||
return ret | |||
})) | |||
} | |||
|
|||
func TestInsertSlice(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func TestInsertSlice(t *testing.T) { | |
func TestSplice(t *testing.T) { |
I made some changes:
|
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.43.0` -> `v1.44.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.43.0/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.43.0/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.44.0`](https://togithub.com/samber/lo/releases/tag/v1.44.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.43.0...v1.44.0) #### What's Changed - feat: Add slice Splice an element or multiple elements at index i. by [@​wenlingang](https://togithub.com/wenlingang) in [https://github.com/samber/lo/pull/371](https://togithub.com/samber/lo/pull/371) - feat: Make Filter() preserve type. by [@​FGasper](https://togithub.com/FGasper) in [https://github.com/samber/lo/pull/365](https://togithub.com/samber/lo/pull/365) - feat: Added DropByIndex helper for slice by [@​phith0n](https://togithub.com/phith0n) in [https://github.com/samber/lo/pull/398](https://togithub.com/samber/lo/pull/398) - feat: upgrade to math/rand/v2 by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/483](https://togithub.com/samber/lo/pull/483) - chore: remove `golang.org/x/exp` since it doesn't follow go 1 compatibility promise by [@​trim21](https://togithub.com/trim21) in [https://github.com/samber/lo/pull/478](https://togithub.com/samber/lo/pull/478) #### New Contributors - [@​wenlingang](https://togithub.com/wenlingang) made their first contribution in [https://github.com/samber/lo/pull/371](https://togithub.com/samber/lo/pull/371) - [@​jason-zhj](https://togithub.com/jason-zhj) made their first contribution in [https://github.com/samber/lo/pull/376](https://togithub.com/samber/lo/pull/376) - [@​FGasper](https://togithub.com/FGasper) made their first contribution in [https://github.com/samber/lo/pull/365](https://togithub.com/samber/lo/pull/365) - [@​phith0n](https://togithub.com/phith0n) made their first contribution in [https://github.com/samber/lo/pull/398](https://togithub.com/samber/lo/pull/398) **Full Changelog**: samber/lo@v1.43.0...v1.44.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.39.0` -> `v1.44.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.39.0/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.39.0/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.44.0`](https://togithub.com/samber/lo/releases/tag/v1.44.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.43.0...v1.44.0) #### What's Changed - feat: Add slice Splice an element or multiple elements at index i. by [@​wenlingang](https://togithub.com/wenlingang) in [https://github.com/samber/lo/pull/371](https://togithub.com/samber/lo/pull/371) - feat: Make Filter() preserve type. by [@​FGasper](https://togithub.com/FGasper) in [https://github.com/samber/lo/pull/365](https://togithub.com/samber/lo/pull/365) - feat: Added DropByIndex helper for slice by [@​phith0n](https://togithub.com/phith0n) in [https://github.com/samber/lo/pull/398](https://togithub.com/samber/lo/pull/398) - feat: upgrade to math/rand/v2 by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/483](https://togithub.com/samber/lo/pull/483) - chore: remove `golang.org/x/exp` since it doesn't follow go 1 compatibility promise by [@​trim21](https://togithub.com/trim21) in [https://github.com/samber/lo/pull/478](https://togithub.com/samber/lo/pull/478) #### New Contributors - [@​wenlingang](https://togithub.com/wenlingang) made their first contribution in [https://github.com/samber/lo/pull/371](https://togithub.com/samber/lo/pull/371) - [@​jason-zhj](https://togithub.com/jason-zhj) made their first contribution in [https://github.com/samber/lo/pull/376](https://togithub.com/samber/lo/pull/376) - [@​FGasper](https://togithub.com/FGasper) made their first contribution in [https://github.com/samber/lo/pull/365](https://togithub.com/samber/lo/pull/365) - [@​phith0n](https://togithub.com/phith0n) made their first contribution in [https://github.com/samber/lo/pull/398](https://togithub.com/samber/lo/pull/398) **Full Changelog**: samber/lo@v1.43.0...v1.44.0 ### [`v1.43.0`](https://togithub.com/samber/lo/releases/tag/v1.43.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.42.0...v1.43.0) #### What's Changed - feat: adding HasKey by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/477](https://togithub.com/samber/lo/pull/477) - feat: adding lo.WaitFor by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/269](https://togithub.com/samber/lo/pull/269) - improvement: Optimize the performance of union method, avoid repeated expansion by [@​cwb2819259](https://togithub.com/cwb2819259) in [https://github.com/samber/lo/pull/397](https://togithub.com/samber/lo/pull/397) #### New Contributors - [@​cwb2819259](https://togithub.com/cwb2819259) made their first contribution in [https://github.com/samber/lo/pull/397](https://togithub.com/samber/lo/pull/397) **Full Changelog**: samber/lo@v1.42.0...v1.43.0 ### [`v1.42.0`](https://togithub.com/samber/lo/releases/tag/v1.42.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.41.0...v1.42.0) #### What's Changed - feat: add Nil by [@​gubtos](https://togithub.com/gubtos) in [https://github.com/samber/lo/pull/383](https://togithub.com/samber/lo/pull/383) - feat: Add First and FirstOrZeroValue functions by [@​Alireza-Kiani](https://togithub.com/Alireza-Kiani) in [https://github.com/samber/lo/pull/451](https://togithub.com/samber/lo/pull/451) - feat: adding LastOrEmpty and LastOr by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/474](https://togithub.com/samber/lo/pull/474) - feat: Feature/contains iterate by index by [@​lennon-guan](https://togithub.com/lennon-guan) in [https://github.com/samber/lo/pull/428](https://togithub.com/samber/lo/pull/428) - feat: speed up loops by reducing allocations by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/475](https://togithub.com/samber/lo/pull/475) - doc: inconsistent expression in README.md by [@​rolancia](https://togithub.com/rolancia) in [https://github.com/samber/lo/pull/406](https://togithub.com/samber/lo/pull/406) #### New Contributors - [@​gubtos](https://togithub.com/gubtos) made their first contribution in [https://github.com/samber/lo/pull/383](https://togithub.com/samber/lo/pull/383) - [@​Alireza-Kiani](https://togithub.com/Alireza-Kiani) made their first contribution in [https://github.com/samber/lo/pull/451](https://togithub.com/samber/lo/pull/451) - [@​rolancia](https://togithub.com/rolancia) made their first contribution in [https://github.com/samber/lo/pull/406](https://togithub.com/samber/lo/pull/406) - [@​lennon-guan](https://togithub.com/lennon-guan) made their first contribution in [https://github.com/samber/lo/pull/428](https://togithub.com/samber/lo/pull/428) **Full Changelog**: samber/lo@v1.41.0...v1.42.0 ### [`v1.41.0`](https://togithub.com/samber/lo/releases/tag/v1.41.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.40.0...v1.41.0) #### What's Changed - feat: adding Elipse by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/470](https://togithub.com/samber/lo/pull/470) - feat: adding CoalesceOrEmpty by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/469](https://togithub.com/samber/lo/pull/469) - feat: adding Earliest and Latest by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/468](https://togithub.com/samber/lo/pull/468) - feat: adding duration by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/471](https://togithub.com/samber/lo/pull/471) - feat: adding FilterReject by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/472](https://togithub.com/samber/lo/pull/472) - feat: adding RejectMap by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/473](https://togithub.com/samber/lo/pull/473) **Full Changelog**: samber/lo@v1.34.0...v1.41.0 ### [`v1.40.0`](https://togithub.com/samber/lo/releases/tag/v1.40.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.39.0...v1.40.0) #### What's Changed ##### Improvements - Use map indexing to speed up PickByKeys and OmitByKeys by [@​ericleb010](https://togithub.com/ericleb010) in [https://github.com/samber/lo/pull/447](https://togithub.com/samber/lo/pull/447) - ToSlicePtr: reduce allocations and improving speed by [@​yanmhlv](https://togithub.com/yanmhlv) in [https://github.com/samber/lo/pull/465](https://togithub.com/samber/lo/pull/465) - Feat: Adding zipby + unzipby by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/449](https://togithub.com/samber/lo/pull/449) - feat: add string conversion functions by [@​eiixy](https://togithub.com/eiixy) in [https://github.com/samber/lo/pull/466](https://togithub.com/samber/lo/pull/466) - Adding Mean and MeanBy by [@​usman1100](https://togithub.com/usman1100) in [https://github.com/samber/lo/pull/414](https://togithub.com/samber/lo/pull/414) ##### Doc & style - Fix typos by [@​szepeviktor](https://togithub.com/szepeviktor) in [https://github.com/samber/lo/pull/384](https://togithub.com/samber/lo/pull/384) - fix: instantiate typo by [@​testwill](https://togithub.com/testwill) in [https://github.com/samber/lo/pull/374](https://togithub.com/samber/lo/pull/374) - Fix typo in README.md by [@​eltociear](https://togithub.com/eltociear) in [https://github.com/samber/lo/pull/369](https://togithub.com/samber/lo/pull/369) - docs: update description for FindOrElse by [@​slomek](https://togithub.com/slomek) in [https://github.com/samber/lo/pull/370](https://togithub.com/samber/lo/pull/370) - style: no extra any type parameter by [@​d-enk](https://togithub.com/d-enk) in [https://github.com/samber/lo/pull/429](https://togithub.com/samber/lo/pull/429) - Fix IsNil link for pkg.go.dev by [@​invzhi](https://togithub.com/invzhi) in [https://github.com/samber/lo/pull/418](https://togithub.com/samber/lo/pull/418) - Docs: should use type int64 for lo.FlatMap in example by [@​apriil15](https://togithub.com/apriil15) in [https://github.com/samber/lo/pull/435](https://togithub.com/samber/lo/pull/435) ##### CI - CI: tests on multi go versions by [@​jiro4989](https://togithub.com/jiro4989) in [https://github.com/samber/lo/pull/445](https://togithub.com/samber/lo/pull/445) #### New Contributors - [@​szepeviktor](https://togithub.com/szepeviktor) made their first contribution in [https://github.com/samber/lo/pull/384](https://togithub.com/samber/lo/pull/384) - [@​testwill](https://togithub.com/testwill) made their first contribution in [https://github.com/samber/lo/pull/374](https://togithub.com/samber/lo/pull/374) - [@​eltociear](https://togithub.com/eltociear) made their first contribution in [https://github.com/samber/lo/pull/369](https://togithub.com/samber/lo/pull/369) - [@​slomek](https://togithub.com/slomek) made their first contribution in [https://github.com/samber/lo/pull/370](https://togithub.com/samber/lo/pull/370) - [@​ericleb010](https://togithub.com/ericleb010) made their first contribution in [https://github.com/samber/lo/pull/447](https://togithub.com/samber/lo/pull/447) - [@​yanmhlv](https://togithub.com/yanmhlv) made their first contribution in [https://github.com/samber/lo/pull/465](https://togithub.com/samber/lo/pull/465) - [@​eiixy](https://togithub.com/eiixy) made their first contribution in [https://github.com/samber/lo/pull/466](https://togithub.com/samber/lo/pull/466) - [@​jiro4989](https://togithub.com/jiro4989) made their first contribution in [https://github.com/samber/lo/pull/445](https://togithub.com/samber/lo/pull/445) - [@​d-enk](https://togithub.com/d-enk) made their first contribution in [https://github.com/samber/lo/pull/429](https://togithub.com/samber/lo/pull/429) - [@​usman1100](https://togithub.com/usman1100) made their first contribution in [https://github.com/samber/lo/pull/414](https://togithub.com/samber/lo/pull/414) - [@​invzhi](https://togithub.com/invzhi) made their first contribution in [https://github.com/samber/lo/pull/418](https://togithub.com/samber/lo/pull/418) - [@​apriil15](https://togithub.com/apriil15) made their first contribution in [https://github.com/samber/lo/pull/435](https://togithub.com/samber/lo/pull/435) **Full Changelog**: samber/lo@v1.39.0...v1.40.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Inserts an element or multiple elements at index i.