Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-compose.yml: version is obsolete #563

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

ZarTek-Creole
Copy link
Contributor

@jcormier jcormier self-requested a review July 10, 2024 21:10
@jcormier jcormier self-assigned this Jul 10, 2024
@jcormier
Copy link
Collaborator

Hmm, I've been thinking about this for a bit and wasn't sure if it was worth changing. The current message is a warning, however, if we fix the warning, then people still using the now deprecated docker-compose command will break with an error.

Granted these files are supposed to be an example, so hopefully no one is using these unchanged...

@jcormier
Copy link
Collaborator

Since no ones complained, I'm going to merge this. Undoing this would be easy for someone stuck on old software so I'll not stress about it.

@jcormier jcormier merged commit d769cbb into sameersbn:master Jul 31, 2024
1 check passed
@ZarTek-Creole ZarTek-Creole deleted the docker-compose.yml_version branch August 1, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants