Skip to content
This repository has been archived by the owner on Nov 25, 2020. It is now read-only.

Added setting constant for throwing exceptions (TCPDF) instead of a die #52

Merged
merged 2 commits into from
Oct 15, 2018

Conversation

kaspervrind
Copy link
Contributor

We had a problem with the TCPDF. A die was executed instead of an exception when an error occurred. TCPDF checks for K_TCPDF_THROW_EXCEPTION_ERROR constant when hitting an error.

Setting k_tcpdf_throw_exception_error: false in config.yml can still execute a die() in TCPDF

@sampart sampart merged commit c07470e into sampart:master Oct 15, 2018
@sampart
Copy link
Owner

sampart commented Oct 15, 2018

Thanks for contributing, @cyberkaa. I appreciate it!

@kaspervrind
Copy link
Contributor Author

@sampart can you please tag the new version so composer can install the new version.

@sampart
Copy link
Owner

sampart commented Oct 17, 2018

@cyberkaa sure thing, here you go: https://github.com/whiteoctober/WhiteOctoberTCPDFBundle/releases/tag/1.1.1 Thanks again

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants