Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacebar does not play/pause video on Plyr.io #2613

Open
benderillo opened this issue Feb 5, 2023 · 2 comments
Open

Spacebar does not play/pause video on Plyr.io #2613

benderillo opened this issue Feb 5, 2023 · 2 comments

Comments

@benderillo
Copy link

Hitting a spacebar does not pause/resume playback when trying on https://plyr.io

Expected behaviour

When hitting spacebar, video should pause/resume

Actual behaviour

Nothing happens

Steps to reproduce

  1. Go to https://plyr.io
  2. Click the video to start playback
  3. Press spacebar

Environment

  • Browsers:
    Safari 15.6 on macOS (Monterey)
    Chrome 109 on macOS (Monterey)
    Opera 94 on macOS (Monterey)
    Chrome on Windows 10
    Edge on Windows 10

Link to where the bug is happening

https://plyr.io

Notes

All the keyboard shortcuts work as expected except the spacebar. I can switch a full screen or control the volume level but I can't play/pause the video with the spacebar.

@benderillo
Copy link
Author

For anyone looking at this issue.
Should be fixed by this PR: #2581

@Kelier
Copy link

Kelier commented Jul 20, 2023

Why Am I able to control fullscreen when I press the space button? Is there any way to uninstall this binding? I think users will naturally associate space with pauses after clicking the fullscreen button?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants