Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed event key with space #2581

Merged
merged 2 commits into from
Dec 31, 2022
Merged

Fixed event key with space #2581

merged 2 commits into from
Dec 31, 2022

Conversation

royeden
Copy link
Contributor

@royeden royeden commented Dec 2, 2022

Link to related issue (if applicable)

#2490

Summary of proposed changes

The library switched from event.keyCode to event.key for listeners here: https://github.com/sampotts/plyr/releases/tag/v3.7.1

But the space bar wasn't working because the event.key for spacebar is an empty space string " ". See the mdn reference.

Thank you for such an asewome library! 😄

Copy link
Owner

@sampotts sampotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants