Dailymotion Support #2136
Open
Dailymotion Support #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DailyMotion doesn't support captions (captions.js) * It provides a new api and sdk plus some config parameters (defaults.js) * Added a new provider type and a regexp rule so it can be selected (types.js) * Added a setup condition inside media.js * Daillymotion Plugin moved inside plugins folder * Added definitions for dailymotion parameters and providers (plyr.d.ts) * Added new function isDailymotion, removed playback rate support for Dailymotion, added a destroy rule for DailyMotion (plyr.js) * New i18n propertie for dailymotion (i18n.js)
Added a dailymotion video example inside index.html.
adeeb1
reviewed
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to related issue (if applicable)
As asked in #682, here is the PR for the dailymotion support.
Summary of proposed changes
Not much, code base wise, has changed, every changes on the original code is to add support for Dailymotion. I also added an example of a dailymotion video.
All the logic of the dailymotion plugin is in plugins/dailymotion.js.