-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add markers #2386
feat: add markers #2386
Conversation
Love this feature! For those interested, I've merged it into my fork with a few additional changes. Here's the PR: ClassHook#8 @ForeverSc feel free to include some of those changes in this PR if you think they're relevant. I'd also be happy to create a separate PR if it's easier. |
@sampotts can we get this merged? |
Thanks! I'll write up some docs and get this published! |
Can you please make a new release with these additions? Latest release doesn't work with the markers. |
Thanks for the work on this. I've made a few small changes to the API (simplified the content to Thanks again. It's in v3.7.0 🎉 |
This is awesome, thanks @sampotts I've been really waiting for this release |
Thanks, @evansque. The current Plyr UI design doesn't really adapt well to chapter/marker support but it's definitely something we'll consider for the Vidstack UI. |
Link to related issue (if applicable)
#278
Summary of proposed changes
add markers option to custom some markers on the progress bar