allow for setting additional listener for captions #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this - I'll run the gulp build Really sorry for the delay |
|
This is in the latest version 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to related issue (if applicable)
Here's a dash.js captions-related issue:
#418
Summary of proposed changes
In order for a plugin to listen for a click on the captions button, this pull request uses
_proxyListenerfor captions. This is one change which might help in cases where the tech used is dash.js, and it would be nice to be able to set an additional listener for captions in any case.Task list
I've tested this on Firefox and Chrome on Linux--which doesn't seem good enough to check the task.
I would gladly complete the Gulp build if there were instructions on how to do so.