Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tabs #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Tabs #9

wants to merge 1 commit into from

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Sep 19, 2015

No description provided.

@phated
Copy link

phated commented Sep 21, 2015

I think this should be broken out into separate components that can be composed, e.g. TabContainer, Tab and Panel (or some variation on those names).

<TabContainer>
  <Tab>Something</Tab>
  <Panel>Content</Panel>
</TabContainer>

I'm not sure the best way to tie <Tab> and <Panel> together. Maybe an id and for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haoxins @phated