Inheritance support #120 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn on inheritance tests. Some whitespace issues. Recursion working but multi standalone broken Make inheritance pass spec tests
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samskivert
This PR adds inheritance support. It currently passes all the spec tests as well as some additional ones I added via custom yaml files.
I have tried not break API by making the Visitor interface use default methods. I'm not sure if the default I chose is correct for blocks and parents (currently skipped).
This should fix #120
Before we add additional optional specification enhancements I think we should do a release. The other optional things like dynamic names are not nearly requested as much and frankly I consider them dangerous but we can add them later.
I tried to follow your formatting but I may have slipped in a few places. I plan on setting up a formatter that follows the style but just haven't gotten around to it yet.