Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SINGULAR platform to read group #1635

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

omicsorama
Copy link
Contributor

Description

This change is to allow Singular Genomics platform id in read groups. This update adds support for new sequencing vendor platform

Things to think about before submitting:

  • [ X ] Make sure your changes compile and new tests pass locally.
  • [ X ] Add new tests or update existing ones:
    • A bug fix should include a test that previously would have failed and passes now.
    • New features should come with new tests that exercise and validate the new functionality.
  • [ X ] Extended the README / documentation, if necessary
  • [ X ] Check your code style.
  • [ X ] Write a clear commit title and message
    • The commit message should describe what changed and is targeted at htsjdk developers
    • Breaking changes should be mentioned in the commit message.

@lbergelson
Copy link
Member

@omicsorama Hello. I see you also have a specs change proposed to add this value. I'm happy to add this update this but I'm going to wait for a bit in case there's any feedback on that pr.

Are you a representative of Singular? Are they producing data with this value at the moment?

@omicsorama
Copy link
Contributor Author

@lbergelson Yes i made the parallel PR to keep docs and tool in step. Makes sense to wait a bit for feedback. Thanks.

Yes I am on the Bioinformatics team at Singular and we are holding off on producing data with this value until our customers can use a published htsjdk version that supports it

Happy to address any other questions!

@lbergelson
Copy link
Member

@omicsorama Thanks for the info. It seems like it should be uncontroversial then if the name is coming straight from the source.

@lbergelson
Copy link
Member

This seems to have been merged in specs so I'm going to merge it. Thank you @omicsorama

@lbergelson lbergelson merged commit 75eac46 into samtools:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants