Make Snappy technically an optional dependency #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Separate SnappyLoader into SnappyLoader and SnappyLoaderInternal This allows SnappyLoader to function (and correclty respond that snappy is not available) in the case where the Snappy libraryis completely missing. Previously it identified and worked around cases where the native code was missing or incompatable, but the java code was required. * Snappy is still marked as a dependency in gradle so downstream projects have to actively opt out of it.
droazen
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
This looks fine to me @lbergelson , provided you've tested both the snappy and no-snappy cases.
|
I tested a good combination of options. IGV with Snappy, snappy excluded but not disabled, and snappy excluded and disabled. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate SnappyLoader into SnappyLoader and SnappyLoaderInternal
This allows SnappyLoader to function (and correctly respond that snappy is not available)
in the case where the Snappy library is completely missing. Previously it identified and
worked around cases where the native code was missing or incompatible, but the java code was required.
Snappy is still marked as a dependency in gradle so downstream projects have to actively opt out of it.
This is needed to work around notarization issues in the IGV mac builds which strongly discourage native code.