Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SamReaderFactory opens non-regular File and Path the same way #1717

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

kshakir
Copy link
Contributor

@kshakir kshakir commented Sep 29, 2024

Description

To close #1716, copies the logic from here:

return wrapper == null
? of(path)
: of(path, wrapper);

Things to think about before submitting:

  • Make sure your changes compile and new tests pass locally.
  • Add new tests or update existing ones:
    • A bug fix should include a test that previously would have failed and passes now.
    • New features should come with new tests that exercise and validate the new functionality.
  • Extended the README / documentation, if necessary
  • Check your code style.
  • Write a clear commit title and message
    • The commit message should describe what changed and is targeted at htsjdk developers
    • Breaking changes should be mentioned in the commit message.

@lbergelson lbergelson merged commit 4c1c766 into samtools:master Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SamReaderFactory.open treats the same non-regular File and Path differently
2 participants